Re: [PATCH 0/3] ASoC: tas2783: fix stereo split and resume on a two-amp pair

[Robin Everaars]

> Robin, Antoine, Andrey -- if you would like Reported-by: or Suggested-by:
> on any of this, say so and I will add it; I did not want to attach your
> names to a series you have not seen.

For patch 2, please add both:

  Reported-by: Robin Everaars <robineveraars@xxxxx>
  Suggested-by: Robin Everaars <robineveraars@xxxxx>

The report and the follow-up measurement established both the one-channel mask
approach and the positional behaviour in sdw_compute_slave_ports(), so those
tags fit. I have no basis for a tag on patches 1 or 3.

I also retested the machine today after booting kernel 7.1.7. The cold-boot path
still fails on the second amplifier:

  command timeout for Slave 2
  trf on Slave 2 failed:-110 write addr 8088 count 32632
  FW download failed: -110
  SDW1 manager is in bad state

The existing reprobe service recovered both amplifiers on its first attempt.
A fresh acoustic run after that recovery gave:

  LEFT only    +69.0 dB over baseline
  RIGHT 
only   +64.4 dB over baseline
  BOTH         +71.0 dB over baseline
  imbalance     +4.6 dB

Both channels reached the speakers.

That measurement only establishes the 7.1.7 baseline; I did not run your
series. My configured out-of-tree module still carries the local per-amp PPU21
write that Pierre correctly rejected as an upstream mechanism. I therefore am
not offering a Tested-by or Reviewed-by for patch 2 yet. I also have not
isolated the residual dev_resume() path for patch 3 on top of b627da430357.

The boot failure is why I am keeping both the boot and resume reprobe services
for now. I will remove them only after the unassisted paths work upstream.

Thanks for the careful follow-up and for separating the prior work from the new
parts of the series.

Attachment: publickey - robineveraars@pm.me - 0x8B6BA132.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: OpenPGP digital signature