Re: [PATCH v4 02/11] KVM: Introduce kvm_create_vm_file() helper

From: tarunsahu

Date: Tue Aug 11 2026 - 09:27:19 EST


Sean Christopherson <seanjc@xxxxxxxxxx> writes:

> On Tue, Jul 28, 2026, Tarun Sahu wrote:
>> - Move ITOA_MAX_LEN to kvm_mm.h for reuse by upcoming kvm_luo code.
>> - Introduce kvm_create_vm_file() to wrap kvm_create_vm() and
>> anon_inode_getfile(), providing a unified VM file creation API.
>
> As Ackerley pointed out, changelogs that are literally a list pretty much always
> needs to be split.
>
> These also need to explain *why*. "providing a unified VM file creation API"
> isn't sufficient justification. In general, all of these changelogs need to
> provide more of the "why"; I can figure out what the patches are doing easily
> enough, but in my speed read of the series, it's hard to figure out the "why".

Okay, Will update them.