Re: [syzbot] [kernel?] memory leak in dev_set_name

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in dev_set_name

BUG: memory leak
unreferenced object 0xffff8881164c8460 (size 16):
  comm "syz.3.25", pid 6755, jiffies 4294947042
  hex dump (first 16 bytes):
    67 61 64 67 65 74 2e 30 00 00 00 00 00 00 00 00  gadget.0........
  backtrace (crc 5823fe15):
    kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
    slab_post_alloc_hook mm/slub.c:4597 [inline]
    slab_alloc_node mm/slub.c:4917 [inline]
    __do_kmalloc_node mm/slub.c:5333 [inline]
    __kmalloc_node_track_caller_noprof+0x3d3/0x570 mm/slub.c:5471
    kvasprintf+0x6e/0xf0 lib/kasprintf.c:25
    kvasprintf_const+0x5c/0x110 lib/kasprintf.c:49
    kobject_set_name_vargs+0x40/0xd0 lib/kobject.c:274
    dev_set_name+0x6d/0x90 drivers/base/core.c:3560
    usb_add_gadget+0x219/0x330 drivers/usb/gadget/udc/core.c:1459
    usb_add_gadget_udc_release drivers/usb/gadget/udc/core.c:1517 [inline]
    usb_add_gadget_udc+0x6e/0xb0 drivers/usb/gadget/udc/core.c:1564
    dummy_udc_probe+0x26c/0x2e0 drivers/usb/gadget/udc/dummy_hcd.c:1121
    platform_probe+0x86/0xf0 drivers/base/platform.c:1439
    call_driver_probe drivers/base/dd.c:628 [inline]
    really_probe+0x12f/0x3a0 drivers/base/dd.c:706
    __driver_probe_device+0xe9/0x1a0 drivers/base/dd.c:868
    device_driver_attach+0x61/0x100 drivers/base/dd.c:1203
    bind_store+0x99/0x110 drivers/base/bus.c:267
    drv_attr_store+0x3c/0x60 drivers/base/bus.c:125
    sysfs_kf_write+0x94/0xb0 fs/sysfs/file.c:145
    kernfs_fop_write_iter+0x1f1/0x2d0 fs/kernfs/file.c:345

BUG: memory leak
unreferenced object 0xffff88810613a000 (size 256):
  comm "syz.3.25", pid 6755, jiffies 4294947042
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 08 a0 13 06 81 88 ff ff  ................
    08 a0 13 06 81 88 ff ff 40 ce 4e 83 ff ff ff ff  ........@.N.....
  backtrace (crc 314e3bdb):
    kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
    slab_post_alloc_hook mm/slub.c:4597 [inline]
    slab_alloc_node mm/slub.c:4917 [inline]
    __kmalloc_cache_noprof+0x356/0x440 mm/slub.c:5485
    _kmalloc_noprof include/linux/slab.h:988 [inline]
    _kzalloc_noprof include/linux/slab.h:1309 [inline]
    device_private_init drivers/base/core.c:3602 [inline]
    device_add+0x740/0xc80 drivers/base/core.c:3653
    usb_add_gadget+0x221/0x330 drivers/usb/gadget/udc/core.c:1461
    usb_add_gadget_udc_release drivers/usb/gadget/udc/core.c:1517 [inline]
    usb_add_gadget_udc+0x6e/0xb0 drivers/usb/gadget/udc/core.c:1564
    dummy_udc_probe+0x26c/0x2e0 drivers/usb/gadget/udc/dummy_hcd.c:1121
    platform_probe+0x86/0xf0 drivers/base/platform.c:1439
    call_driver_probe drivers/base/dd.c:628 [inline]
    really_probe+0x12f/0x3a0 drivers/base/dd.c:706
    __driver_probe_device+0xe9/0x1a0 drivers/base/dd.c:868
    device_driver_attach+0x61/0x100 drivers/base/dd.c:1203
    bind_store+0x99/0x110 drivers/base/bus.c:267
    drv_attr_store+0x3c/0x60 drivers/base/bus.c:125
    sysfs_kf_write+0x94/0xb0 fs/sysfs/file.c:145
    kernfs_fop_write_iter+0x1f1/0x2d0 fs/kernfs/file.c:345
    new_sync_write fs/read_write.c:595 [inline]
    vfs_write+0x3ac/0x720 fs/read_write.c:687
    ksys_write+0xa5/0x170 fs/read_write.c:739
    do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
    do_syscall_64+0xf8/0x610 arch/x86/entry/syscall_64.c:94

BUG: memory leak
unreferenced object 0xffff888114256130 (size 16):
  comm "syz.1.26", pid 6769, jiffies 4294947100
  hex dump (first 16 bytes):
    67 61 64 67 65 74 2e 30 00 00 00 00 00 00 00 00  gadget.0........
  backtrace (crc 5823fe15):
    kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
    slab_post_alloc_hook mm/slub.c:4597 [inline]
    slab_alloc_node mm/slub.c:4917 [inline]
    __do_kmalloc_node mm/slub.c:5333 [inline]
    __kmalloc_node_track_caller_noprof+0x3d3/0x570 mm/slub.c:5471
    kvasprintf+0x6e/0xf0 lib/kasprintf.c:25
    kvasprintf_const+0x5c/0x110 lib/kasprintf.c:49
    kobject_set_name_vargs+0x40/0xd0 lib/kobject.c:274
    dev_set_name+0x6d/0x90 drivers/base/core.c:3560
    usb_add_gadget+0x219/0x330 drivers/usb/gadget/udc/core.c:1459
    usb_add_gadget_udc_release drivers/usb/gadget/udc/core.c:1517 [inline]
    usb_add_gadget_udc+0x6e/0xb0 drivers/usb/gadget/udc/core.c:1564
    dummy_udc_probe+0x26c/0x2e0 drivers/usb/gadget/udc/dummy_hcd.c:1121
    platform_probe+0x86/0xf0 drivers/base/platform.c:1439
    call_driver_probe drivers/base/dd.c:628 [inline]
    really_probe+0x12f/0x3a0 drivers/base/dd.c:706
    __driver_probe_device+0xe9/0x1a0 drivers/base/dd.c:868
    device_driver_attach+0x61/0x100 drivers/base/dd.c:1203
    bind_store+0x99/0x110 drivers/base/bus.c:267
    drv_attr_store+0x3c/0x60 drivers/base/bus.c:125
    sysfs_kf_write+0x94/0xb0 fs/sysfs/file.c:145
    kernfs_fop_write_iter+0x1f1/0x2d0 fs/kernfs/file.c:345

BUG: memory leak
unreferenced object 0xffff888131551700 (size 256):
  comm "syz.1.26", pid 6769, jiffies 4294947140
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 08 17 55 31 81 88 ff ff  ..........U1....
    08 17 55 31 81 88 ff ff 40 ce 4e 83 ff ff ff ff  ..U1....@.N.....
  backtrace (crc 8a06d131):
    kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
    slab_post_alloc_hook mm/slub.c:4597 [inline]
    slab_alloc_node mm/slub.c:4917 [inline]
    __kmalloc_cache_noprof+0x356/0x440 mm/slub.c:5485
    _kmalloc_noprof include/linux/slab.h:988 [inline]
    _kzalloc_noprof include/linux/slab.h:1309 [inline]
    device_private_init drivers/base/core.c:3602 [inline]
    device_add+0x740/0xc80 drivers/base/core.c:3653
    usb_add_gadget+0x221/0x330 drivers/usb/gadget/udc/core.c:1461
    usb_add_gadget_udc_release drivers/usb/gadget/udc/core.c:1517 [inline]
    usb_add_gadget_udc+0x6e/0xb0 drivers/usb/gadget/udc/core.c:1564
    dummy_udc_probe+0x26c/0x2e0 drivers/usb/gadget/udc/dummy_hcd.c:1121
    platform_probe+0x86/0xf0 drivers/base/platform.c:1439
    call_driver_probe drivers/base/dd.c:628 [inline]
    really_probe+0x12f/0x3a0 drivers/base/dd.c:706
    __driver_probe_device+0xe9/0x1a0 drivers/base/dd.c:868
    device_driver_attach+0x61/0x100 drivers/base/dd.c:1203
    bind_store+0x99/0x110 drivers/base/bus.c:267
    drv_attr_store+0x3c/0x60 drivers/base/bus.c:125
    sysfs_kf_write+0x94/0xb0 fs/sysfs/file.c:145
    kernfs_fop_write_iter+0x1f1/0x2d0 fs/kernfs/file.c:345
    new_sync_write fs/read_write.c:595 [inline]
    vfs_write+0x3ac/0x720 fs/read_write.c:687
    ksys_write+0xa5/0x170 fs/read_write.c:739
    do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
    do_syscall_64+0xf8/0x610 arch/x86/entry/syscall_64.c:94

connection error: failed to recv *flatrpc.ExecutorMessageRawT: EOF


Tested on:

commit:         d58772d8 Merge tag 'regmap-fix-v7.2-rc7' of git://git...
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15722a9e580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=6843f8fd2336602d
dashboard link: https://syzkaller.appspot.com/bug?extid=87ce68d9f48eca96a84a
compiler:       gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
patch:          https://syzkaller.appspot.com/x/patch.diff?x=166e12c6580000