Re: [PATCH v4 2/6] KVM: x86/xen: Extract delivery of event to vCPU into a separate helper

From: David Woodhouse

Date: Tue Aug 11 2026 - 09:53:43 EST


On Tue, 2026-08-11 at 13:49 +0100, David Woodhouse wrote:
> From: Sean Christopherson <seanjc@xxxxxxxxxx>
>
> Move the marking of an event as pending in the target vCPU's vcpu_info
> into a separate helper, __kvm_xen_set_evtchn_fast(), invoked after the
> shared_info processing is complete and its RCU read-side critical
> section has been exited. This makes both halves easier to read.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> [dwmw2: rebased onto the RCU conversion of the GPC locking; the
>  read_trylock() failure path in the original no longer exists. The
>  caller's kvm->srcu section now extends across the helper call, since
>  kvm_gpc_check() on the vcpu_info cache consults the memslot
>  generation and the irqfd path enters holding only irq_srcu; in Sean's
>  series that was covered by a guard(srcu) spanning the whole function,
>  which this series does not carry.]
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
> Assisted-by: Claude:claude-mythos-5
> ---
>  arch/x86/kvm/xen.c | 155 ++++++++++++++++++++++++++++-----------------
>  1 file changed, 98 insertions(+), 57 deletions(-)

Meh, Gmail.

Here's a nickel. kid...

urezki@xxxxxxxxx
host gmail-smtp-in.l.google.com [2a00:1450:4009:c19::1a]
SMTP error from remote mail server after end of data:
550-5.7.1 [2001:8b0:10b:1:d65d:64ff:fe57:4e05 12] Gmail has detected that
550-5.7.1 this message is likely unsolicited mail. To reduce the amount of spam
550-5.7.1 sent to Gmail, this message has been blocked. For more information,
550-5.7.1 go to
550 5.7.1 https://support.google.com/mail/?p=UnsolicitedMessageError ffacd0b85a97d-4814a746e5csi3185414f8f.195 - gsmtp
boqun.feng@xxxxxxxxx
host gmail-smtp-in.l.google.com [2a00:1450:4009:c19::1a]
SMTP error from remote mail server after end of data:
550-5.7.1 [2001:8b0:10b:1:d65d:64ff:fe57:4e05 12] Gmail has detected that
550-5.7.1 this message is likely unsolicited mail. To reduce the amount of spam
550-5.7.1 sent to Gmail, this message has been blocked. For more information,
550-5.7.1 go to
550 5.7.1 https://support.google.com/mail/?p=UnsolicitedMessageError ffacd0b85a97d-4814a746e5csi3185414f8f.195 - gsmtp

Attachment: smime.p7s
Description: S/MIME cryptographic signature