Re: [PATCH v5 0/2] This series cleans up unused module parameters from the atomisp driver.

[Andy Shevchenko]

On Wed, Jul 22, 2026 at 11:16:13AM +0530, Prajval Chaudhary wrote:
> Patch 1 converts 'pad_w' and 'pad_h' module parameters into internal
> driver defines (ATOMISP_PAD_W and ATOMISP_PAD_H).
> Patch 2 removes 'dbg_level' and 'dbg_func' module parameters and updates
> ia_css_debug_vdtrace() to filter trace logging to IA_CSS_DEBUG_WARNING
> level or below to avoid potential dmesg log flooding.
> 
> Output Behavior Difference:
> - Before: Trace logging depended on setting dbg_level via module
>   parameters. Higher values flooded dmesg with verbose low-level trace
>   messages.
> - After: Trace logging is filtered at IA_CSS_DEBUG_WARNING via standard
>   vprintk facilities, avoiding dmesg flooding while maintaining
>   critical warnings.

Why do you think this is good enough? I already pointed out that this
needs the report from the field, id est showing the before and after on
real hardware. Also I mentioned that printk() is not good for low-level
traces and we _have_ the mechanisms for that kind of messages, exempli
gratia trace events and trace points.

-- 
With Best Regards,
Andy Shevchenko