Re: [PATCH] mailbox: cix: validate channel parameters early and convert to dev_err_probe

From: Jassi Brar

Date: Tue Aug 11 2026 - 13:47:40 EST


On Fri, Jul 24, 2026 at 1:42 AM <kr494167@xxxxxxxxx> wrote:
>
> From: Surendra Singh Chouhan <kr494167@xxxxxxxxx>
>
> cix_mbox_startup() checked fast channel index constraints (index < 0 ||
> index > CIX_MBOX_FAST_IDX) inside the channel switch block after
> calling request_irq(). If validation failed, it triggered a free_irq()
> cleanup path. Validating channel parameters prior to request_irq()
> avoids unnecessary IRQ registration/teardown churn.
>
> In addition, cix_mbox_probe() logged property errors referencing
> "cix,mbox_dir" (with an underscore) instead of the actual DT property
> name "cix,mbox-dir". Convert cix_mbox_probe() error paths to use
> dev_err_probe() and fix the DT property string spelling.
>
These should be two patches.

Thanks
Jassi