[PATCH 0/5] power: supply: qcom_smbx: fix watchdog and battery properties
From: Robin Snyders via B4 Relay
Date: Tue Aug 11 2026 - 19:33:44 EST
Fix five bugs in the existing Qualcomm SMB2 charger driver.
The watchdog bark handler omits the charger peripheral base and can write
an unrelated SPMI register. Battery health handling compares the complete
status register instead of testing its independent fault bits. The
float-voltage calculation is one selector step too high, and its battery
target is neither selected nor validated safely. Finally, the
battery-overvoltage IRQ ignores read errors and only publishes assertion,
leaving health and status stale after the falling-edge recovery interrupt.
The float-voltage validation patch prefers the constant-charge target,
falls back to the design voltage, and preserves the firmware setting when
both optional properties are absent. It also restores the pre-probe
charging-enable state if hardware initialization or any later probe step
fails, preventing probe failure from changing that state.
All five issues were introduced with the driver. The patches carry the
same Fixes tag and are marked for stable.
This series is also the declared prerequisite for the SMB5 v2 series,
whose driver refactoring overlaps the health, overvoltage and
float-voltage code.
The driver builds with LLVM W=1 and passes sparse without driver
warnings. All five patches pass checkpatch --strict.
Based on linux-next 20260811 (5e6de6a2b522).
Signed-off-by: Robin Snyders <robin@xxxxxxxxxxx>
---
Robin Snyders (5):
power: supply: qcom_smbx: include base when petting watchdog
power: supply: qcom_smbx: test battery health status bits
power: supply: qcom_smbx: fix float voltage selector
power: supply: qcom_smbx: validate battery float voltage
power: supply: qcom_smbx: notify battery overvoltage recovery
drivers/power/supply/qcom_smbx.c | 98 ++++++++++++++++++++++++++++++++--------
1 file changed, 78 insertions(+), 20 deletions(-)
---
base-commit: 5e6de6a2b522f659defacb1551d0465ba6ce13cf
change-id: 20260812-qcom-smbx-fixes-4c2ab163cc9c
Best regards,
--
Robin Snyders <robin@xxxxxxxxxxx>