Re: [PATCH 03/17] rust: pci: expose the allocated interrupt type

[Danilo Krummrich]

On Tue Aug 11, 2026 at 5:09 AM CEST, John Hubbard wrote:
> On 8/10/26 3:53 PM, Danilo Krummrich wrote:
>> On Sun Aug 9, 2026 at 11:42 PM CEST, John Hubbard wrote:
>>> Yes, please. Then my patches 2 and 3 collapse into a single patch that
>>> adds count(), irq_type() and an index-to-IrqVector accessor. Or, they go
>>> away entirely if you end up putting those on the type yourself.
>> 
>> I sent out a patch series [1] for this, applied your nova-core patches on top of
>> it and resolved the conflicts with the diff below (also pushed a branch in [2]).
>> 
>> Note that I optimized for a clean diff and not for optimal code. I think there
>> are more improvements we can make; I will comment on the corresponding patches
>> of this series.
>
> I've folded your series and the fixups into a v2 work-in-progress branch, here:
>
>     https://github.com/johnhubbard/linux/tree/nova-core-gin-interrupt-tree-v2
>
> Let me know if it would be better for me to post that now, given that the
> earlier parts are all different now.

Thanks! I think it's fine as is, will go over the series on Thursday.

I've sent a v2 (and updated the branch I shared previously), as I think
preserving the source of IRQ via the anchor type doesn't really add a lot of
value and keeping IrqVector as a new type over IrqRequest turns out nicer. The
changes required from v1 to v2 should be minimal.