Re: [PATCH v5 2/4] i2c: add Andes I2C driver support

From: Ben Zong-You Xie

Date: Tue Aug 11 2026 - 23:32:41 EST


On Tue, Aug 11, 2026 at 09:37:12AM +0200, Christophe JAILLET wrote:
>
> Le 11/08/2026 à 08:29, Ben Zong-You Xie via B4 Relay a écrit :
> > From: Ben Zong-You Xie <ben717@xxxxxxxxxxxxx>
> >
> > Add support for Andes I2C driver. Andes I2C can act as either a
> > controller or a target, depending on the control register settings. Now,
> > we only support controller mode.
> >
> > Signed-off-by: Ben Zong-You Xie <ben717@xxxxxxxxxxxxx>
>

Hi CJ,

> ...
>
> > +static struct i2c_algorithm andes_i2c_algo = {
>
> Could this be const?

Yes, I will add const in v6.

> > + .xfer = andes_i2c_xfer,
> > + .functionality = andes_i2c_func,
> > +};
> CJ

Thanks,
Ben