Re: [PATCH] staging: media: atomisp: Remove spaces at the start of a line

From: Andy Shevchenko

Date: Wed Aug 12 2026 - 04:23:58 EST


On Sun, Jul 26, 2026 at 10:08:10PM -0300, Diego Schild Smiths wrote:
> Fix checkpatch.pl warnings:
> WARNING: please, no spaces at the start of a line

Describe the problem in plain English. Do not dump some tool output to the face
of the reader of this.

> Signed-off-by: Diego Schild Smiths <diegossmiths@xxxxxxxxxxxx>

While fixing indentation in the code, the Subject is wrong.

...

> void
> -ia_css_eed1_8_vmem_encode(
> - struct eed1_8_vmem_params *to,
> - const struct ia_css_eed1_8_config *from,
> - size_t size)
> +ia_css_eed1_8_vmem_encode(struct eed1_8_vmem_params *to,
> + const struct ia_css_eed1_8_config *from,
> + size_t size)

I believe there are much more of the cases.

...

Please, read lore.kernel.org linux-media@ archives against this driver to
understand why this patch is no-go.

Also, if you are in a group that is mentored, tell to the mentors to stop
looking into this driver by a newbie. This driver has much more urgent tasks
to do and it's not trivial, it also requires a real HW to be at hand to test.

--
With Best Regards,
Andy Shevchenko