Re: [PATCH v4 2/2] iio: adc: ti-ads112c04: Add support for TI ADS112C04

[Kyle Hsieh]

On Wed, Aug 12, 2026 at 3:30 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
...

> You quoted tons of comments to which you haven't replied. Are you agree with
> them?

Sorry - I agreed with all of them and have already applied them in v5,
I just didn't say so. To be explicit:

- wait_for_completion_timeout() is now used directly in the if condition
- err/ret swapped in ads112c04_wait_for_data()
- i is unsigned int, declared separately from the assignment
- reference-sources uses fwnode_property_match_property_string()
- single-channel has its own variable instead of reusing pair[0]
- ARRAY_SIZE(pair) instead of the hardcoded 2
- fsleep(1 * USEC_PER_MSEC) instead of fsleep(1000)
- the internal reference macro is ADS112C04_INT_REF_mV and now sits at
  the top of the file with the other defines
- the IRQ is no longer disabled at all, so the unbalanced depth issue
  is gone

I'll trim quoted text and reply per comment from now on.

...

> I'm not sure how the binding might be affected by that. reset-gpio should be
> direct replacement of the custom "reset" GPIO handling in the driver.

You're right, I had that wrong - reset-gpio builds the reset controller
from the existing reset-gpios property, so the binding is unchanged and
David's Reviewed-by is unaffected. Switched to
devm_reset_control_get_optional_exclusive() in v5.

Thanks,
Kyle Hsieh