[PATCH v2] lib/test_hmm: fix garbage pfn and wrong direction in devmem fault debug
From: liuqiangneo
Date: Wed Aug 12 2026 - 05:42:56 EST
From: Qiang Liu <liuqiang@xxxxxxxxxx>
Move pr_debug() inside the `if (dpage)` block to avoid
printing garbage pfn for NULL dpage, and correct the
direction label from "sys to dev" to "dev to sys".
Assisted-by: Qoder:Qwen-3.8-MAX-Preview
Signed-off-by: Qiang Liu <liuqiang@xxxxxxxxxx>
---
v1->v2:
- Rebase from mm-everything to mm-new.
- Change commit message.
Link to v1:
https://lore.kernel.org/all/20260811092256.102101-1-liuqiangneo@xxxxxxx/
---
lib/test_hmm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/test_hmm.c b/lib/test_hmm.c
index 6205fb313bd0..7c4d10eae6fe 100644
--- a/lib/test_hmm.c
+++ b/lib/test_hmm.c
@@ -1151,10 +1151,9 @@ static vm_fault_t dmirror_devmem_fault_alloc_and_copy(struct migrate_vma *args,
if (!dpage && !order)
return VM_FAULT_OOM;
- pr_debug("migrating from sys to dev pfn src: 0x%lx pfn dst: 0x%lx\n",
- page_to_pfn(spage), page_to_pfn(dpage));
-
if (dpage) {
+ pr_debug("migrating from dev to sys pfn src: 0x%lx pfn dst: 0x%lx\n",
+ page_to_pfn(spage), page_to_pfn(dpage));
lock_page(dpage);
*dst |= migrate_pfn(page_to_pfn(dpage));
}
--
2.43.0
No virus found
Checked by Hillstone Network AntiVirus