Re: [PATCH v7 02/43] fscrypt: allow inline encryption for extent based encryption

[Daniel Vacek]

On Tue, 2 Jun 2026 at 00:49, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> On Wed, May 13, 2026 at 10:52:36AM +0200, Daniel Vacek wrote:
> > From: Josef Bacik <josef@xxxxxxxxxxxxxx>
> >
> > Instead of requiring -o inlinecrypt to enable inline encryption, allow
> > having s_cop->has_per_extent_encryption to indicate that this file
> > system supports inline encryption.
> >
> > Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
> > Signed-off-by: Daniel Vacek <neelx@xxxxxxxx>
> > ---
> >
> > v5: https://lore.kernel.org/linux-btrfs/ba0289bf103653d5d98ef576756c9a2a66192865.1706116485.git.josef@xxxxxxxxxxxxxx/
> >  * No changes since.
>
> There are multiple places that check SB_INLINECRYPT, and just one was
> updated.  Perhaps we should just require that if a filesystem sets
> has_per_extent_encryption, then it also sets SB_INLINECRYPT
> unconditionally?

has_per_extent_encryption means the kernel fs implementation supports
extent encryption, not that the mounted filesystem uses encryption.
That said it would result in all btrfs mounts setting SB_INLINECRYPT.
Is that what you meant?

--nX

> - Eric