Re: [PATCH 1/8] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY

[Marek Vasut]

On 8/12/26 1:22 PM, Krzysztof Kozlowski wrote:
> On 12/08/2026 12:56, Marek Vasut wrote:
> > On 8/12/26 12:15 PM, Krzysztof Kozlowski wrote:
> > > On Wed, Aug 12, 2026 at 02:55:41AM +0200, Marek Vasut wrote:
> > > > From: Pankaj Dev <pankaj.dev@xxxxxx>
> > > >
> > > > Document USB2 PHY for STM32MP25 USB2 controllers, which includes the
> > > > USB2.0 host-only controller and USB 2.0 part of the DWC3 controller.
> > > > Two such PHYs in total are present in STM32MP25 SoC, they both are
> > > > slightly different, therefore they use different compatible string
> > >
> > > What is slightly different? This should be either here, or better, in
> > > "description" part.
> >
> > They are both Synopsys FEMTO-PHY , but they are each attached to a
> > different controller (one to USB 2.0 host , the other to DWC3 DRD) , and
> > their control bits in the system controller register are different for
> > each variant.
> >
> > I extended the description in V2.
>
> Depending on the actual difference, this rather belongs to the phandle
> to syscon, instead of separate compatible.

Modeling that in the phandle to syscon won't scale, the PHY driver is 
simple thus far and does not control all the bits in that syscon, if we 
were to somehow extend the phandle to syscon to describe the various bit 
mappings and differences in it, it would look awful quickly. Hence the 
separate compatible strings, so the driver can match on them, derive 
match data from them and use the match data to figure out differences of 
each instance.

> > > > to discern them.
> > > >
> > > > Signed-off-by: Clément Le Goffic <clement.legoffic@xxxxxxxxxxx>
> > > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
> > > > Signed-off-by: Marek Vasut <marex@xxxxxxxxxxxx>
> > > > Signed-off-by: Pankaj Dev <pankaj.dev@xxxxxx>
> > > > Signed-off-by: Rahul Kumar <rahul.kumar05@xxxxxx>
> > >
> > > Incomplete/incorrect DCO chain. Who sends it? Rahul?
> > This is lifted from the ST downstream kernel fork, it's a combination of
> > a bunch of commits there and then cleaned up. Pankaj and Fabrice did
> > most of the downstream work, I did the clean up for upstreaming. I
> > collected the SoB lines from all the commits from ST downstream fork and
> > added mine, hence this list. How shall I address this correctly, with
> > some Co-developed-by tag ? Who gets which tag ?
>
> Everything explained in submitting patches. The SoBs represent the
> chronological lifecyle of the patch. Person sending the patch is
> obviously the last one touching. How Rahul could touch the code AFTER
> you sent it?
Fixed for all patches in V2, thanks.