Re: [PATCH net-next v2 2/2] net: dsa: realtek: rtl83xx: add support for enabling supplies

From: Luiz Angelo Daros de Luca

Date: Wed Aug 12 2026 - 16:05:03 EST


> On Tue, Aug 11, 2026 at 1:39 PM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
> > From: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> >
> > The power supplies powering the IC may not necessarily be enabled by the
> > time the driver probes. The binding describes the power rails, so enable
> > them at probe with devm_regulator_bulk_get_enable(), before the reset line
> > is requested and driven, so the chip is powered before its pins are driven.
> >
> > Boards that do not describe these supplies fall back to dummy regulators
> > (with a "supply not found" warning) and keep working as before.
> >
> > A board that describes supplies but no reset line still needs to wait for
> > the chip to boot before the first register access, so apply the existing
> > start delay in that case too.
> >
> > Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> > Co-developed-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>
> Kudos for all the detailed explanations!
> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
>
> Yours,
> Linus Walleij

Nice work. Thanks.

Reviewed-by: Luiz Angelo Daros de Luca <luizluca@xxxxxxxxx>