Re: [PATCH 1/2] dt-bindings: display: panel: Add bindings for Novatek NT37703

[Esteban Urrutia]

On 8/12/26 7:52 AM, Neil Armstrong wrote:
> On 8/12/26 10:46, David Heidelberg wrote:
>> bit I missed in the review the part:
>>
>> +            compatible = "motorola,bronco-tianma-v2-nt37703", "novatek,nt37703";
>>
>> Unless the driver is able to auto-detect the connected panel (unlikely), novatek,nt37703 doesn't make sense. The DDIC without the panel is useless.
>>
>> For example, in sdm845-oneplus-fajita and enchilada, we have the generic compatible because it was introduced before, so it's kept for compatibility reasons. There is no need to do that here.
> 
> Yeah today the norm is to add the ddic as second compatible entry so the first compatible just describes the pane, so here it should be:
> 
> compatible = "motorola,bronco-tianma-v2", "novatek,nt37703";
In that case first compatible string should be
"tianma,motorola-bronco-v2" since Tianma is the panel maker and this
"v2" panel is only used in motorola-bronco.

Regards,
Esteban