Re: [PATCH v4 1/7] mm/khugepaged: refactor per-scan state clearing into collapse_control_init_scan()

[Nico Pache (Red Hat)]

On 8/12/26 3:23 AM, Pedro Falcato wrote:
> On Tue, Aug 11, 2026 at 06:48:33AM -0600, Nico Pache (Red Hat) wrote:
>> Extract the repeated clearing of node_load, alloc_nmask, and
>> mthp_present_ptes into a helper to reduce duplication in
>> collapse_scan_pmd() and collapse_scan_file(). Althought file scans do not
>> current use the bitmap, they will in the future, and clearing it now is
> 
> Will they? (To be clear, not opposed to clearing this regardless).

That is the hope at least. Baolin has a series for this:
https://lore.kernel.org/lkml/cover.1781083630.git.baolin.wang@xxxxxxxxxxxxxxxxx/

The plan is to do these cleanups first then Baolin will base on that work.

> 
>> harmless.
>>
>> Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
>> Acked-by: Usama Arif <usama.arif@xxxxxxxxx>
>> Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
>> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
>> Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
>> Signed-off-by: Nico Pache (Red Hat) <nico.pache@xxxxxxxxx>
> 
> Reviewed-by: Pedro Falcato <pfalcato@xxxxxxx>

Thank you for reviewing :)

-- Nico

>