Re: [PATCH v3 1/3] hwmon: (asus_rog_ryujin) Add per-device configuration

[Guenter Roeck]

On Wed, Aug 12, 2026 at 06:35:30AM -0400, Arie Miller wrote:
> Move model-specific report offsets and capabilities into a device
> information structure. This prepares the driver for coolers which use
> a different report layout or do not include the external fan
> controller, while preserving the existing Ryujin II 360 behavior.
> 
> Handles an issue reported by Sashiko where an id could
> be missing driver_data.

This is introduced by this patch and thus irrelevant for the commit
message.

> 
> Link: https://lore.kernel.org/r/5a817284-a9f4-48b2-9f0f-802c5dc6963c@xxxxxxxxxxxx
> Assisted-by: Codex:gpt-5.6-sol sparse
> Signed-off-by: Arie Miller <renari@xxxxxxxxxx>

We are too close for me to accept this series without independent
Tested-by: and/or Reviewed-by: feedback. I plan to apply it after
the next commit window closes.

I won't mandate that the issues reported by Sashiko are getting fixed,
but I wuold strongly suggest for the users of this driver to have a look
and consider fixing them. The issues look very real to me.

Thanks,
Guenter