Re: [PATCH v7 1/2] dt-bindings: mfd: x-powers: Add AC200

From: Krzysztof Kozlowski

Date: Thu Aug 13 2026 - 02:49:52 EST


On Tue, Aug 11, 2026 at 05:11:30PM -0600, James Hilliard wrote:
> The AC200 is an I2C-controlled mixed-signal companion IC containing
> audio, video, RTC and Fast Ethernet PHY functions.
>
> Describe the parent device and its shared input clock. The Ethernet PHY
> is represented by a PHY package on its MDIO bus, with a phandle back to
> this device for access to the package control registers, so it does not
> require an MFD child node. Function-specific supplies belong to their
> consumer bindings rather than the shared parent.

Other way to represent it is to put ethernet phy here - either as a
child or folded into MFD device node - and provide phandle to MDIO bus.
We do like this already for several devices for I2C case with "i2c-bus"
property. Here it would be "mdio-bus" for example. Such solution feels
more vendor-agnostic, easier to re-use, however I cannot find any actual
arguments against your approach.

Maybe Rob will have his preference, but this looks okay for me then:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof