Re: [PATCH v2 1/2] dt-bindings: power: supply: qcom,pmi8998-charger: add SMB5 PMICs
From: Krzysztof Kozlowski
Date: Thu Aug 13 2026 - 04:53:23 EST
On Wed, Aug 12, 2026 at 01:56:59AM +0200, Robin Snyders wrote:
> From: Casey Connolly <casey.connolly@xxxxxxxxxx>
>
> Add compatible strings for PM7250B and PM8150B, which contain the SMB5
> generation of the Qualcomm switch-mode battery charger. PM7250B uses the
> same charger interface and parameters as PM8150B, so require the PM8150B
> compatible as its fallback.
>
> Clarify the IIO channel descriptions because SMB5 exposes a USB current-
> sense voltage while SMB2 exposes an already-converted current.
>
> Signed-off-by: Casey Connolly <casey.connolly@xxxxxxxxxx>
> Signed-off-by: Robin Snyders <robin@xxxxxxxxxxx>
I don't get one thing - you used b4 to send it, so how could this be
threaded to some other email thread? Do not introduce custom workflows,
please. b4 is there to make it right, so just use it in standard way -
b4 trailers, b4 prep -c, b4 prep --edit-cover, b4 prep --check, b4 send.
> ---
> .../bindings/power/supply/qcom,pmi8998-charger.yaml | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
Best regards,
Krzysztof