Re: arch/m68k/include/asm/nettel.h:60: undefined reference to `ppdata'

[Geert Uytterhoeven]

Hi Kernel Test Robot,

On Thu, 13 Aug 2026 at 13:36, kernel test robot <lkp@xxxxxxxxx> wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   3d6d817622b0a9721e3cc404df3469171582be13
> commit: f47c1b77d0a2a9c0d49ec14302e74f933398d1a3 clk: Move clk_{save,restore}_context() to COMMON_CLK section
> date:   7 months ago
> config: m68k-randconfig-r071-20260813 (https://download.01.org/0day-ci/archive/20260813/202608131917.ZNBnMX82-lkp@xxxxxxxxx/config)
> compiler: m68k-linux-gcc (GCC) 10.5.0
> smatch: v0.5.0-9187-g5189e3fb
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260813/202608131917.ZNBnMX82-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Fixes: f47c1b77d0a2 ("clk: Move clk_{save,restore}_context() to COMMON_CLK section")
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202608131917.ZNBnMX82-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
>    m68k-linux-ld: arch/m68k/coldfire/nettel.o: in function `init_nettel':
> >> arch/m68k/include/asm/nettel.h:60: undefined reference to `ppdata'
> >> m68k-linux-ld: arch/m68k/include/asm/nettel.h:60: undefined reference to `ppdata'
> >> m68k-linux-ld: arch/m68k/include/asm/nettel.h:60: undefined reference to `ppdata'
>    m68k-linux-ld: arch/m68k/include/asm/nettel.h:61: undefined reference to `ppdata'
> >> m68k-linux-ld: arch/m68k/include/asm/nettel.h:60: undefined reference to `ppdata'
>    m68k-linux-ld: arch/m68k/coldfire/nettel.o:arch/m68k/include/asm/nettel.h:61: more undefined references to `ppdata' follow

This looks like a false positive, as this commit cannot cause these
additional failures.  In fact the parent commit doesn't even build
with the provided .config?

> vim +60 arch/m68k/include/asm/nettel.h
>
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16  55
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16  56  static __inline__ void mcf_setppdata(unsigned int mask, unsigned int bits)
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16  57  {
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16  58   volatile unsigned short *pp;
> 732c611e5bbb76 arch/m68k/include/asm/nettel.h sfking@xxxxxxxxx 2009-06-19  59   pp = (volatile unsigned short *) MCFSIM_PADAT;
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16 @60   ppdata = (ppdata & ~mask) | bits;
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16  61   *pp = ppdata;
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16  62  }
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16  63  #endif
> ^1da177e4c3f41 include/asm-m68knommu/nettel.h Linus Torvalds   2005-04-16  64

The provided .config has CLEOPATRA enabled:

    arch/m68k/Kconfig.machine:config CLEOPATRA
    arch/m68k/Kconfig.machine:      bool "Feith CLEOPATRA board support"
    arch/m68k/Kconfig.machine-      depends on (M5307 || M5407)

while ppdata is not provided by M5307 or M5407, but only by
M5272 and M5307:

    arch/m68k/coldfire/m5272.c:unsigned short ppdata;
    arch/m68k/coldfire/m5307.c:unsigned short ppdata;

There is a similar issue with NETtel:

    arch/m68k/Kconfig.machine:config NETtel
    arch/m68k/Kconfig.machine:      bool "SecureEdge/NETtel board support"
    arch/m68k/Kconfig.machine-      depends on (M5206e || M5272 || M5307)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds