Re: [PATCH v2 1/2] ASoC: dt-bindings: es8316: Add regulator supplies

[Hongyang Zhao]

On Wed, Aug 12, 2026 at 05:35:43PM +0800, Hongyang Zhao wrote:
> > The ES8316 has separate AVDD, CPVDD, DVDD and PVDD supply inputs for
> > its analog, charge pump, digital core and digital I/O domains. Describe
> > all four inputs so boards can model the codec power topology.
> > 
> > The binding also covers ES8311 and ES8323, whose supply inputs differ,
> > so restrict these properties to the ES8316 compatible. Keep them
> > optional for compatibility with existing descriptions.
> > 
> > Signed-off-by: Hongyang Zhao <hongyang.zhao@xxxxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/sound/everest,es8316.yaml  | 27 ++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/everest,es8316.yaml b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> > index fe5d938ca310..276c73bb4790 100644
> > --- a/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> > +++ b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> > @@ -30,6 +30,17 @@ description: |
> >  
> >  allOf:
> >    - $ref: dai-common.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: everest,es8316
> > +    else:
> 
> Missing 'then'. You need to invert the 'if'.
> 
> Looks like Mark already applied, so you'll need to send incremental
> patch.

Thanks for pointing this out. I understand the issue now.

I inverted the condition, moved the supply restrictions under `then`,
and sent an incremental fix against the applied commit:

https://lore.kernel.org/r/20260813-b4-es8316-binding-conditional-fix-v1-1-6cd56aa1370c@xxxxxxxxxxxxxxx

I also verified the fix with dt_binding_check using the latest
dtschema.

Thanks,
Hongyang