Re: [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible

From: Rob Herring

Date: Thu Aug 13 2026 - 15:21:03 EST


On Wed, Aug 12, 2026 at 02:41:14PM +0200, Esben Haabendal wrote:
> "Rob Herring" <robh@xxxxxxxxxx> writes:
>
> > On Mon, Aug 10, 2026 at 09:11:13AM +0200, Esben Haabendal wrote:
> >> LTR-329ALS-01 is an ambient light sensor similar to LTR-303ALS-01, but
> >> without interrupt support.
> >>
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> >> Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> >> Signed-off-by: Esben Haabendal <esben@xxxxxxxxxx>
> >> ---
> >> Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml | 1 +
> >> 1 file changed, 1 insertion(+)
> >
> > sashiko issue should be addressed.
>
> I will.
>
> I guess it is best to add the new conditional statement under allOf, but
> as we already have an allOf block at the top, I would have to add it
> under that, which would place this new conditional statement related to
> specific compatible strings before the list of those compatible strings.
>
> It should work fine, but it looks a bit odd to me.
>
> I could also add it directly as an if statement, but that would only
> work as long as it is the only top level if statement, so that looks
> like a bad idea.
>
> Should I just stick it to the existing allOf list?

You can move the allOf to the end.

Rob