[PATCH 02/03] fbdev: maxine: elide an unused function

From: Randy Dunlap

Date: Thu Aug 13 2026 - 19:30:57 EST


maxinefb_ims332_read_register() is not used, but since it describes a
hardware interface, leave it in the source file as documentation
and surround it inside an #if 0/#endif block.

../drivers/video/fbdev/maxinefb.c:74:21: warning: 'maxinefb_ims332_read_register' defined but not used [-Wunused-function]
74 | static unsigned int maxinefb_ims332_read_register(int regno)

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
---
Cc: Helge Deller <deller@xxxxxx>
Cc: linux-fbdev@xxxxxxxxxxxxxxx
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
Cc: "Maciej W. Rozycki" <macro@xxxxxxxxxxx>

drivers/video/fbdev/maxinefb.c | 3 +++
1 file changed, 3 insertions(+)

--- linux-next-20260812.orig/drivers/video/fbdev/maxinefb.c
+++ linux-next-20260812/drivers/video/fbdev/maxinefb.c
@@ -71,6 +71,8 @@ static void maxinefb_ims332_write_regist
*((volatile unsigned short *) (wptr)) = val;
}

+#if 0
+/* dead code: leave here for hardware interface documentation */
static unsigned int maxinefb_ims332_read_register(int regno)
{
register unsigned char *regs = (char *) MAXINEFB_IMS332_ADDRESS;
@@ -83,6 +85,7 @@ static unsigned int maxinefb_ims332_read

return (j & 0xffff) | ((k & 0xff00) << 8);
}
+#endif

/* Set the palette */
static int maxinefb_setcolreg(unsigned regno, unsigned red, unsigned green,