Re: [PATCH v8 6/9] perf c2c: add function view hierarchy entry creation

From: Namhyung Kim

Date: Fri Aug 14 2026 - 02:15:59 EST


On Fri, Aug 14, 2026 at 11:23:06AM +0800, Jiebin Sun wrote:
> Hi Namhyung,
>
> > What if both DSOs are NULL?
>
> If both are NULL, the outer condition is true, but
> left_dso != right_dso is false. The function therefore skips the DSO name
> comparison and reaches the final _sort__sym_cmp() call, using the symbols
> to distinguish the entries instead.

Ah, ok. I misread the code that it may return undefined result or crash.

Thanks,
Namhyung