Re: [PATCH v3 2/2] serial: 8250_dw: add Ambarella CV75 quirks

[Andy Shevchenko]

On Thu, Aug 13, 2026 at 06:35:13PM +0800, Long Zhao via B4 Relay wrote:

> Add CV75 platform data with an ETOI IER mask and skip-set-rate so the
> DesignWare 8250 driver can drive the Ambarella UART for console use.

...

> +	/* Keep variant-specific bits in the shadow across subsequent updates. */

This says what code is doing. Instead it must say "why?" the code is doing this.

> +	up->ier |= d->pdata->ier_mask;
> +	serial_port_out(p, UART_IER, up->ier);

...

In case there is an HW bug, where can we get the errata, please? (For a bare
minimum add a reference to the Errata document you give to the customers.)

-- 
With Best Regards,
Andy Shevchenko