Re: [PATCH v2 1/5] gpio: rtd1625: Minor coding style cleanups

From: Andy Shevchenko

Date: Fri Aug 14 2026 - 08:05:45 EST


On Fri, Aug 14, 2026 at 10:56:53AM +0800, Yu-Chun Lin wrote:
> Address a few coding style issues:
> - Drop redundant initialization.
> - Remove an unnecessary blank line in rtd1625_gpio_setup_irq().
> - And move the comment closer to the related code for better context.

Not sure if this needs to be split to two patches (the second item doesn't
really belongs to it). With that being split out, the Subject may be corrected
to the point of _this_ change, id est "Drop unneeded 'ret' assignment", and
in the commit message something like "While at it, place correctly the comment
to be just above the referenced code."

--
With Best Regards,
Andy Shevchenko