Re: [PATCH] powerpc: fsl_rio: Use snprintf() in fsl_rio_setup()

[Thorsten Blum]

On Fri, Aug 14, 2026 at 02:26:24PM +0200, Christophe Leroy (CS GROUP) wrote:
> Le 30/06/2026 à 16:49, Thorsten Blum a écrit :
> > While the current code works correctly, replace the unbounded sprintf()
> > with the safer snprintf() in fsl_rio_setup() to follow secure coding
> > best practices.
> > 
> > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> > ---
> >   arch/powerpc/sysdev/fsl_rio.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
> > index eb55dabb4748..077c03cd93e4 100644
> > --- a/arch/powerpc/sysdev/fsl_rio.c
> > +++ b/arch/powerpc/sysdev/fsl_rio.c
> > @@ -612,7 +612,7 @@ static int fsl_rio_setup(struct platform_device *dev)
> >   				kfree(port);
> >   				continue;
> >   		}
> > -		sprintf(port->name, "RIO mport %d", i);
> > +		snprintf(port->name, sizeof(port->name), "RIO mport %d", i);
> 
> Are you sure it is correct ?
> 
> Shouldn't it be sizeof(port->name) - 1 ?

snprintf() takes the destination buffer size (including the NUL) as its
second argument, so sizeof(port->name) should be correct.