Re: [PATCH v24 net-next 02/11] net/nebula-matrix: add core driver architecture and HW layer initialization

[Jakub Kicinski]

On Fri,  7 Aug 2026 12:44:06 +0800 illusion.wang wrote:
> +	err = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));

Documentation says:

  dma_set_mask_and_coherent() never return fail when DMA_BIT_MASK(64)

Please, don't error check this :/

> +	if (err) {
> +		dev_dbg(dev, "Configure DMA 64 bit mask failed, err = %d\n",
> +			err);
> +		err = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
> +		if (err) {
> +			dev_err(dev,
> +				"Configure DMA 32 bit mask failed, err = %d\n",
> +				err);
> +			goto configure_dma_err;