Re: [PATCH v3] profiling: don't free prof_cpu_mask on init failure

[Bradley Morgan]

Ummmm, not sure you should replace it with that long of a comment,

What you did was meant to cleanup useless crap. Let's not add more 
useless crap by adding 7 new lines. When it could be explained shorter
IMHO, Here's a example, I mean, its not the best, but it works:

/* No need to free prof_cpu_mask()
 * anymore, the error path is rare
 * and the leak is harmless IMHO 
 */


feel free to bikeshed. As per usual.


Also, here's some stable "rules" I tell most people

- Please please please add why this is bad in the commit description (you did that! Yay)

- A splat, please. It helps the stable folks not think that this is another "bug" (Do this if possible)


If I had to say "Bradley, just review this patch for what it does for f*ck
sake", I'd say this patch is useful (sorry for my french!)

So.. here is the tag to add for V4,

Reviewed-by: Bradley Morgan <include@xxxxxxxxx>


Thanks!