Re: [PATCH v2] ntb: fix tx descriptor leak on dmaengine_submit failure
From: kernel test robot
Date: Fri Aug 14 2026 - 22:08:23 EST
Hi WenTao,
kernel test robot noticed the following build errors:
[auto build test ERROR on jonmason-ntb/ntb-next]
[also build test ERROR on linus/master v7.2-rc7 next-20260813]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/WenTao-Liang/ntb-fix-tx-descriptor-leak-on-dmaengine_submit-failure/20260815-061001
base: https://github.com/jonmason/ntb ntb-next
patch link: https://lore.kernel.org/r/20260628083301.9781-1-vulab%40iscas.ac.cn
patch subject: [PATCH v2] ntb: fix tx descriptor leak on dmaengine_submit failure
config: alpha-allmodconfig (https://download.01.org/0day-ci/archive/20260815/202608150920.Q3iV5WrW-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260815/202608150920.Q3iV5WrW-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608150920.Q3iV5WrW-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/ntb/ntb_transport.c: In function 'ntb_async_rx_submit':
>> drivers/ntb/ntb_transport.c:1577:9: error: implicit declaration of function 'dmaengine_desc_put'; did you mean 'dmaengine_desc_free'? [-Wimplicit-function-declaration]
1577 | dmaengine_desc_put(txd);
| ^~~~~~~~~~~~~~~~~~
| dmaengine_desc_free
vim +1577 drivers/ntb/ntb_transport.c
1515
1516 static int ntb_async_rx_submit(struct ntb_queue_entry *entry, void *offset)
1517 {
1518 struct dma_async_tx_descriptor *txd;
1519 struct ntb_transport_qp *qp = entry->qp;
1520 struct dma_chan *chan = qp->rx_dma_chan;
1521 struct dma_device *device;
1522 size_t pay_off, buff_off, len;
1523 struct dmaengine_unmap_data *unmap;
1524 dma_cookie_t cookie;
1525 void *buf = entry->buf;
1526
1527 len = entry->len;
1528 device = chan->device;
1529 pay_off = (size_t)offset & ~PAGE_MASK;
1530 buff_off = (size_t)buf & ~PAGE_MASK;
1531
1532 if (!is_dma_copy_aligned(device, pay_off, buff_off, len))
1533 goto err;
1534
1535 unmap = dmaengine_get_unmap_data(device->dev, 2, GFP_NOWAIT);
1536 if (!unmap)
1537 goto err;
1538
1539 unmap->len = len;
1540 unmap->addr[0] = dma_map_phys(device->dev, virt_to_phys(offset),
1541 len, DMA_TO_DEVICE, 0);
1542 if (dma_mapping_error(device->dev, unmap->addr[0]))
1543 goto err_get_unmap;
1544
1545 unmap->to_cnt = 1;
1546
1547 unmap->addr[1] = dma_map_phys(device->dev, virt_to_phys(buf),
1548 len, DMA_FROM_DEVICE, 0);
1549 if (dma_mapping_error(device->dev, unmap->addr[1]))
1550 goto err_get_unmap;
1551
1552 unmap->from_cnt = 1;
1553
1554 txd = device->device_prep_dma_memcpy(chan, unmap->addr[1],
1555 unmap->addr[0], len,
1556 DMA_PREP_INTERRUPT);
1557 if (!txd)
1558 goto err_get_unmap;
1559
1560 txd->callback_result = ntb_rx_copy_callback;
1561 txd->callback_param = entry;
1562 dma_set_unmap(txd, unmap);
1563
1564 cookie = dmaengine_submit(txd);
1565 if (dma_submit_error(cookie))
1566 goto err_set_unmap;
1567
1568 dmaengine_unmap_put(unmap);
1569
1570 qp->last_cookie = cookie;
1571
1572 qp->rx_async++;
1573
1574 return 0;
1575
1576 err_set_unmap:
> 1577 dmaengine_desc_put(txd);
1578 err_get_unmap:
1579 dmaengine_unmap_put(unmap);
1580 err:
1581 return -ENXIO;
1582 }
1583
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki