Re: [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible

[Jonathan Cameron]

On Fri, 14 Aug 2026 12:39:45 +0000
Esben Haabendal <esben@xxxxxxxxxx> wrote:

> On Friday, August 14th, 2026 at 08:18, Esben Haabendal <esben@xxxxxxxxxx> wrote:
> 
> > On Monday, August 10th, 2026 at 17:50, Rob Herring <robh@xxxxxxxxxx> wrote:
> >   
> > > On Mon, Aug 10, 2026 at 09:11:13AM +0200, Esben Haabendal wrote:  
> > > > LTR-329ALS-01 is an ambient light sensor similar to LTR-303ALS-01, but
> > > > without interrupt support.
> > > >
> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > > > Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> > > > Signed-off-by: Esben Haabendal <esben@xxxxxxxxxx>
> > > > ---
> > > >  Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)  
> > >
> > > sashiko issue should be addressed.  
> > 
> > What about the suggestion about adding `proximity-near-level: false` to the condition. I am thinking something like this is more correct
> > 
> > properties:
> >   proximity-near-level: false
> > 
> > allOf:
> >   - if:
> >       properties:
> >         compatible:
> >           contains:
> >             enum:
> >               - liteon,ltr501
> >               - liteon,ltr559
> >     then:
> >       properties:
> >         proximity-near-level: true
> > 
> > As it is only valid for those two chips, and it seems more logical to do a white-list than the opposite.  
> 
> I hope it is okay to do this change in a follow-up series to this one, so we can get it merged sooner rather than later.

Whilst this looks to be in a good state to merge, timing is such that
it is next cycle material anyway at this point unfortunately.
So if you don't mind tidying this up as part of your series, I'd
definitely prefer that.

Thanks,

Jonathan
> 
> /Esben