Re: [PATCH 2/2] misc: tc9564: introduce base PCI driver

[Krzysztof Kozlowski]

On 14/08/2026 18:55, Alex Elder wrote:
> On 8/14/26 2:03 AM, Krzysztof Kozlowski wrote:
>> On Thu, Aug 13, 2026 at 05:29:42PM -0500, Alex Elder wrote:
>>> +static struct pci_driver tc9564_function_driver = {
>>> +	.name		= DRIVER_NAME,
>>> +	.id_table	= tc9564_function_id_table,
>>> +	.probe		= tc9564_function_probe,
>>> +	.remove		= tc9564_function_remove,
>>> +	.driver		= {
>>> +		.name		= DRIVER_NAME,
>>> +		.owner		= THIS_MODULE,
>>
>> You just copied some old driver. Why do you need this?
> 
> What do you mean I "just copied some old driver"?
> 
> I do now see that a PCI driver doesn't need to set it,
> because pci_register_driver() sets it automatically.
> 
> I will remove that in the next version.

Old driver because we removed it 13 years ago from all drivers and only
a few left-overs were still hanging around.

Best regards,
Krzysztof