Re: [PATCH v2 10/15] accel/qda: Add GEM_CREATE and GEM_MMAP_OFFSET IOCTLs
From: Ekansh Gupta
Date: Tue Aug 18 2026 - 01:54:23 EST
On 18-08-2026 09:19, Dmitry Baryshkov wrote:
> On Mon, Aug 17, 2026 at 10:17:45AM +0530, Ekansh Gupta wrote:
>> Expose two new DRM IOCTLs that allow user-space to allocate DMA-backed
>> GEM buffer objects and retrieve their mmap offsets.
>>
>> DRM_IOCTL_QDA_GEM_CREATE (drm_qda_gem_create)
>> Allocates a DMA-coherent GEM buffer of the requested size. The
>> memory manager assigns an IOMMU context bank to the calling process
>> on first use and performs the DMA allocation against that bank.
>> Returns a GEM handle that identifies the buffer for subsequent
>> operations.
>>
>> DRM_IOCTL_QDA_GEM_MMAP_OFFSET (drm_qda_gem_mmap_offset)
>> Returns the mmap offset for an existing GEM handle. The offset can
>> be passed directly to mmap() to map the buffer into user-space.
>> Imported DMA-BUF objects are rejected by drm_gem_dumb_map_offset().
>>
>> DRIVER_GEM is added to driver_features now that GEM IOCTLs are
>> present.
>>
>> Assisted-by: Claude:claude-sonnet-5
>> Signed-off-by: Ekansh Gupta <ekansh.gupta@xxxxxxxxxxxxxxxx>
>> ---
>> drivers/accel/qda/qda_drv.c | 4 +++-
>> drivers/accel/qda/qda_ioctl.c | 50 +++++++++++++++++++++++++++++++++++++++++++
>> drivers/accel/qda/qda_ioctl.h | 2 ++
>> include/uapi/drm/qda_accel.h | 36 +++++++++++++++++++++++++++++++
>> 4 files changed, 91 insertions(+), 1 deletion(-)
>>
>
> The patch LGTM. THe commit messages needs a rewrite
will fix to commit message, thanks.>