Re: [PATCH v3] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management

[lijun]

Thank you!  This suggestion is very useful to me.
--------
I think the same is needed for your firmware/arm_scmi patch and also for
the bluetooth one.

The usage of DEFINE_SIMPLE_DEV_PM_OPS() is an improvement, but now you
have (at least) three series in flight and the trivial feedback you
received here applies to all three. As someone who also sends many
patches, I recommend to get up to speed slowly. Work on a single patch
first, and only once you get that in---or at least positive feedback on
it---address one or two further drivers. When you have a handful of
patches in, you can speed up. But as it is now, you only occupy many
people finding the same issues in your patches.

2026/8/20 13:04, Uwe Kleine-König :
> I think the same is needed for your firmware/arm_scmi patch and also for
> the bluetooth one.
>
> The usage of DEFINE_SIMPLE_DEV_PM_OPS() is an improvement, but now you
> have (at least) three series in flight and the trivial feedback you
> received here applies to all three. As someone who also sends many
> patches, I recommend to get up to speed slowly. Work on a single patch
> first, and only once you get that in---or at least positive feedback on
> it---address one or two further drivers. When you have a handful of
> patches in, you can speed up. But as it is now, you only occupy many
> people finding the same issues in your patches.