Re: [PATCH 0/4] net: broadcom: Improve IRQ error handling

[Bui Duc Phuc]

Hi Florian, Chen,

Thank you for your feedback.

> >
> > Not seeing much value in these patches, to be honest.
>

I was looking at how platform_get_irq_optional() is handled in other
network drivers, such as the Xilinx and TI drivers:
Xilinx :
https://elixir.bootlin.com/linux/v7.2/source/drivers/net/ethernet/xilinx/xilinx_axienet_main.c#L3020
TI :
https://elixir.bootlin.com/linux/v7.2/source/drivers/net/ethernet/ti/davinci_emac.c#L1444

Both drivers explicitly handle errors returned by
platform_get_irq_optional() rather than treating every negative value
as "no IRQ".
I wonder if they handled it this way because their hardware and software
are already solid. I used these implementations as references when
considering the error handling in these patches.

> Agreed. I prefer the current behavior. Even if the optional WoL IRQ
> exist, but fails to initialize correctly, the rest of the network
> functions will still work. No need to take down everything in this case.
>

What about -EPROBE_DEFER? Do you also want to ignore it and not
give the driver a chance to probe again?


Best regards,
Phuc