Re: [PATCH 1/6] mm/gup: move gup_can_follow_protnone() to gup.c

[Barry Song]

On Sun, Aug 23, 2026 at 8:17 PM Mike Rapoport (Microsoft)
<rppt@xxxxxxxxxx> wrote:
>
> gup_can_follow_protnone() is defined in include/linux/mm.h but only used
> by mm/gup.c.
>
> First, there is no reason to have it in already gigantic header.
>
> Next, the upcoming refactoring of userfaultfd flags will make
> gup_can_follow_protnone() depend on userfaultfd_k.h which would cause a
> cyclic header dependency.
>
> Move gup_can_follow_protnone() to mm/gup.c.
>
> No functional change.
>
> Assisted-by: copilot:claude-opus-5
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> ---

LGTM, thanks!

Reviewed-by: Barry Song <baohua@xxxxxxxxxx>