[PATCH v2 0/8] Add Aspeed AST2700 SDRAM EDAC support
From: Ryan Chen
Date: Sun Aug 23 2026 - 22:46:32 EST
Add ECC error reporting for the Aspeed AST2700 SoC to the existing
aspeed_edac driver.
The AST2700 memory controller keeps the same overall EDAC programming
model as the earlier Aspeed BMC SoCs, but uses a different register
layout, a split interrupt status/clear/mask scheme and DDR4/DDR5 memory.
Rather than fork the driver, the existing code is first tidied and
generalised, then the AST2700 is added as one more per-SoC variant.
Patches 2-5 are bug fixes and cleanups to the existing driver. Patches 6
and 7 rework the implementation to accommodate the AST2700. Patch 8 adds
the AST2700 support itself.
Signed-off-by: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx>
---
Changes in v2:
- New patch: free the ECC interrupt before the mem_ctl_info in
aspeed_remove(). The interrupt is requested with devm_request_irq() and
is only released after .remove() has returned, so edac_mc_free() could
free the handler's context while the handler was still running on
another CPU.
- Acquire the register lock with the irqsave variant in init_csrows() and
in aspeed_probe(). The interrupt handler takes the same lock in hardirq
context, so taking it with interrupts enabled would have tripped lockdep
on the first reported error.
- Move the dev_dbg() of the interrupt status register out of the
raw_spinlock critical section in the interrupt handler.
- Opt aspeed_edac.o into context analysis in drivers/edac/Makefile. The
check is opt-in per object, so without it the __guarded_by() annotation
added by the same patch was never actually verified.
- Return IRQ_NONE from ast2700_dramc_isr() when no ECC interrupt status
bit is set; the handler clears only the ECC bits, so unconditionally
claiming the interrupt could livelock the level-triggered line.
- Tested v2 on both AST2600 and AST2700 by injecting a correctable
error with the memory controller's ECC error injection; each is
reported as a CE with the expected failure address.
- Link to v1: https://lore.kernel.org/r/20260812-edac-v1-0-03992edea297@xxxxxxxxxxxxxx
---
Ryan Chen (8):
dt-bindings: edac: aspeed: Add AST2700 SDRAM EDAC
EDAC/aspeed: Set the DIMM grain
EDAC/aspeed: Free the interrupt before the mem_ctl_info on remove
EDAC/aspeed: Clean up whitespace and include ordering
EDAC/aspeed: Free the mem_ctl_info unconditionally on remove
EDAC/aspeed: Replace regmap with direct register access
EDAC/aspeed: Abstract SoC differences behind chip data
EDAC/aspeed: Add AST2700 support
.../bindings/edac/aspeed,ast2400-sdram-edac.yaml | 6 +-
drivers/edac/Makefile | 1 +
drivers/edac/aspeed_edac.c | 426 ++++++++++++++-------
3 files changed, 284 insertions(+), 149 deletions(-)
---
base-commit: 5464985e42c04e335fb30e38fbc409c997db9bec
change-id: 20260625-edac-8e960e02e7f7
Best regards,
--
Ryan Chen <ryan_chen@xxxxxxxxxxxxxx>