Re: [PATCH v3] platform/chrome: cros_ec_proto: Fix deferred response
From: Tzung-Bi Shih
Date: Mon Aug 24 2026 - 01:47:49 EST
On Wed, Aug 19, 2026 at 02:18:07PM -0700, Rob Barnes wrote:
> v3:
> - Rebase against upstream chrome-platform/for-firmware-next tree (Tzung-Bi).
It needs to rebase to "for-next" actually. But anyway, that wasn't the
original comment... It's fine as long as the patch generated against to
the correct base.
> - Fix MIME/email transport line-wrapping and formatting issues (Tzung-Bi).
It seems the issue is still there.
> diff --git a/drivers/platform/chrome/cros_ec_proto.c
> b/drivers/platform/chrome/cros_ec_proto.c
> index 1d8d9168ec1a..6d7c57e381e5 100644
> --- a/drivers/platform/chrome/cros_ec_proto.c
> +++ b/drivers/platform/chrome/cros_ec_proto.c
> @@ -138,7 +138,8 @@ static int cros_ec_xfer_command(struct
> cros_ec_device *ec_dev, struct cros_ec_co
The hunk header shouldn't wrap.
./scripts/checkpatch.pl --strict:
#48: FILE: drivers/platform/chrome/cros_ec_proto.c:137:
cros_ec_device *ec_dev, struct cros_ec_co
total: 1 errors, 0 warnings, 0 checks, 251 lines checked