Re: [PATCH v6 2/2] iio: adc: ti-ads112c04: Add support for TI ADS112C04

[Andy Shevchenko]

On Mon, Aug 24, 2026 at 04:09:14PM +0800, Kyle Hsieh wrote:
> On Fri, Aug 21, 2026 at 6:59 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > On Thu, Aug 20, 2026 at 03:51:52PM +0800, Kyle Hsieh wrote:

...

> > > +     /*
> > > +      * Datasheet: td(RSSTA), the delay from the RESET rising edge to the
> > > +      * first I2C START, is 100ns minimum.
> >
> > This is order of magnitude delay. Do you mean 100 盜? (Actually would be good to
> > use Greek letter in the units, looks much cleaner in the comments.)
> >
> > > +      */
> > > +     fsleep(1 * USEC_PER_MSEC);
> >
> > Otherwise this should be simply 1 (no multiplier).
> The datasheet says 100ns minimum, so the comment was right but the delay
> was far longer than needed. Changed to fsleep(1) and used µs in the
> comment.

Note, we have ndelay(), so using it as ndelay(100) might be even better.

-- 
With Best Regards,
Andy Shevchenko