Re: [PATCH v2 13/14] arm64: dts: qcom: ipq5018: Enable USB Super-Speed PHY

[George Moussalem]

On 8/24/26 13:03, Konrad Dybcio wrote:
> On 8/12/26 11:34 AM, George Moussalem via B4 Relay wrote:
>> From: George Moussalem <george.moussalem@xxxxxxxxxxx>
>>
>> Add the 5V supply regulator and enable USB Super-Speed PHY support.
>>
>> Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts
>> index 8efb2b21ed9e..ca29f271e673 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts
>> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts
>> @@ -22,6 +22,14 @@ aliases {
>>  	chosen {
>>  		stdout-path = "serial0:115200n8";
>>  	};
>> +
>> +	regulator_fixed_5p0: regulator-s0500 {
>> +		compatible = "regulator-fixed";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +		regulator-name = "fixed_5p0";
>> +		gpios = <&tlmm 24 GPIO_ACTIVE_LOW>;
>> +	};
>>  };
>>  
>>  &blsp1_uart1 {
>> @@ -119,6 +127,12 @@ &usbphy0 {
>>  	status = "okay";
>>  };
>>  
>> +&usbphy1 {
>> +	vdd-supply = <&regulator_fixed_5p0>;
> 
> I think we'd see fireworks if this chip got a 5v input. I'd assume
> this probably needs the usual-for-qcom 0.9 V and 1.2 V regulator pair,
> but perhaps +Kathiravan can confirm whether this holds for the router
> SoCs too..

I've taken it from:
https://lore.kernel.org/all/20230929084209.3033093-8-quic_ipkumar@xxxxxxxxxxx/

and 5V is also mentioned in one of the vendor init scripts for Linksys
MR5500 to enable USB which is GPIO controlled.

It would indeed be good if Kathiravan can confirm..

> 
> Konrad

Thanks,
George