Re: [PATCH] arm64: dts: lx2160a: fix incorrect pinmux

[Josua Mayer]

Am 24.08.26 um 00:24 schrieb Vincent Jardin via B4 Relay:
> From: Vincent Jardin <vjardin@xxxxxxx>
>
> For gpio1 value set for pinctrl is outside the mask and so will do
> nothing.
> Add the missing offset for value field to be the same as the mask as
> expected.
>
> Fixes: 284ad7064aaa ("arm64: dts: lx2160a: complete pinmux for rcwsr12 configuration word")
> Signed-off-by: Vincent Jardin <vjardin@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 1d73abffa6b7..b9f079c49e19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -1803,7 +1803,7 @@ fspi_data74_pins: xspi1-data74-pins {
>  			};
>  
>  			gpio1_31_28_pins: xspi1-data74-gpio-pins {
> -				pinctrl-single,bits = <0x0 0x1 (0x7 << 15)>;
> +				pinctrl-single,bits = <0x0 (0x1 << 15) (0x7 << 15)>;
>  			};
>  
>  			fspi_data30_pins: xspi1-data30-pins {
> @@ -1811,7 +1811,7 @@ fspi_data30_pins: xspi1-data30-pins {
>  			};
>  
>  			gpio1_27_24_pins: xspi1-data30-gpio-pins {
> -				pinctrl-single,bits = <0x0 0x1 (0x7 << 18)>;
> +				pinctrl-single,bits = <0x0 (0x1 << 18) (0x7 << 18)>;
>  			};
>  
>  			fspi_dqs_sck_cs10_pins: xspi1-base-pins {
> @@ -1819,7 +1819,7 @@ fspi_dqs_sck_cs10_pins: xspi1-base-pins {
>  			};
>  
>  			gpio1_23_20_pins: xspi1-base-gpio-pins {
> -				pinctrl-single,bits = <0x0 0x1 (0x7 << 21)>;
> +				pinctrl-single,bits = <0x0 (0x1 << 21) (0x7 << 21)>;
>  			};
>  
>  			esdhc0_cmd_data30_clk_vsel_pins: sdhc1-base-sdhc-vsel-pins {
>
> ---
> base-commit: 3d6d817622b0a9721e3cc404df3469171582be13
> change-id: 20260824-for-upstream-lx2160a-pinmux-fix-6d09e82bd5cb
>
> Best regards,
Thanks!

Reviewed-by: Josua Mayer <josua@xxxxxxxxxxxxx>