Re: [PATCH v2 2/3] ksmbd: initialize FileSystemControlFlags in FS_CONTROL_INFORMATION

[Namjae Jeon]

On Mon, Aug 24, 2026 at 7:23 PM Aleksandr Khromov <haa@xxxxxxxxx> wrote:
>
> smb2_get_info_filesystem() reports 48 bytes for FS_CONTROL_INFORMATION,
> that is the whole of struct smb2_fs_control_info, but never assigns
> FileSystemControlFlags.  Those four bytes go to the client as they are
> found in the response buffer.
>
> The buffer is zeroed on allocation, so a standalone request leaks
> nothing.  A compound request can leak: the offset of the next response
> is advanced by the length pinned for the previous one, so a reply that
> was written into the buffer and then dropped in favour of the short
> error response of smb2_set_err_rsp() stays there, and the next reply is
> laid over it with only the header cleared.
>
> ksmbd does not implement quota tracking, so report no control flags.
>
> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Aleksandr Khromov <haa@xxxxxxxxx>
Applied it to #ksmbd-for-next.
Thanks!