Re: [PATCH] pmdomain: renesas: rcar-sysc: Update description of chan_offs

[Geert Uytterhoeven]

Hi Ayman,

On Fri, 21 Aug 2026 at 17:09, Ayman Chaudhry
<ayman.chaudhry.kc@xxxxxxxxxxx> wrote:
> The description of `rcar_sysc_area.chan_offs` does not clearly document
> how the field is used.
>
> When `rcar_sysc_area.flags` is set to `PD_ALWAYS_ON`,
> `rcar_sysc_area.chan_offs` gets ignored, therefore improve the
> description of `rcar_sysc_area.chan_offs` to make it clear that the
> field is set to 0 if power is always on.
>
> Signed-off-by: Ayman Chaudhry <ayman.chaudhry.kc@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/pmdomain/renesas/rcar-sysc.h
> +++ b/drivers/pmdomain/renesas/rcar-sysc.h
> @@ -29,7 +29,7 @@
>
>  struct rcar_sysc_area {
>         const char *name;
> -       u16 chan_offs;          /* Offset of PWRSR register for this area */
> +       u16 chan_offs;          /* PWRSR register offset; or 0 if area is always on */
>         u8 chan_bit;            /* Bit in PWR* (except for PWRUP in PWRSR) */
>         u8 isr_bit;             /* Bit in SYSCI*R */

The same is true for chan_bit, and almost true for irs_bit, too.
So I'd rather correct all three comments at once.

>         s8 parent;              /* -1 if none */

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds