Re: [PATCH REGRESSION] um: Fix cpu_feature_enabled() build breakage
From: Borislav Petkov
Date: Mon Aug 24 2026 - 10:25:19 EST
On Mon, Aug 24, 2026 at 11:22:33AM +0100, Fabian Franz wrote:
> >
> > Thanks for this pointer.
> >
> > > https://lore.kernel.org/all/20260819-uml-timex-fix-v1-1-f690b514fc9f@xxxxxxxxxxxxx/
> >
> > Indeed, both our fixes seem to be for the same breakage.
> >
> > Personally I prefer my patch, as it reverts the specific change which
> > introduced the breakage into the tree. Franz' change does not look incorrect
> > but is a larger change and should go through a regular release cycle.
>
> I also prefer your patch. It is much simpler and doesn't require
> changing the cpu flags at all.
>
> However, getting the minimal patch for um in ASAP would also be good,
> as a broken master is not nice for development.
It happens during the merge window.
UML folks, you wanna take Thomas' patch or should I route it through tip?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette