Re: [PATCH v2] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW

[Marc Zyngier]

On Sun, 23 Aug 2026 19:08:32 +0100,
Julian Braha <julianbraha@xxxxxxxxx> wrote:
> 
> ARM_GIC_V3 currently selects HAVE_ARM_SMCCC_DISCOVERY without ensuring its
> dependency, ARM_PSCI_FW, is met. However, ARM_PSCI_FW is always enabled on
> for arm64, and the GICv3 driver only uses HAVE_ARM_SMCCC_DISCOVERY to
> identify the NVIDIA T241, which is arm64 anyway.
> 
> Also adds fallbacks for callers to avoid needing #ifdef guards when
> HAVE_ARM_SMCCC_DISCOVERY is disabled (32bit arm).

What does this 'Also' tell you? That this part is in the wrong patch.

This should be split in two different patches, fixing different
problems.  One to allow graceful fallback of the SMCCC_DISCOVERY stuff
when it isn't selected, and another to only force the selection of
that option on arm64 when GICv3 is selected.

>
> This unmet dependency was found by kconfirm, a static analysis tool for
> Kconfig.

I'm not sure this is massively relevant here, but since the trend is
to turn commit messages into advertising billboards...

	M.

-- 
Jazz isn't dead. It just smells funny.