Re: [PATCH v2 07/12] f2fs: cache: use node cache
From: Chao Yu
Date: Tue Aug 25 2026 - 02:38:51 EST
On 8/25/26 13:43, Wenjie Qi wrote:
Hi Chao,
entry = xa_load(&META_CACHE(sbi)->root, nid);
if (entry)
return;
entry = f2fs_grab_node_cache(sbi, nid);
The first lookup uses `nid` against `META_CACHE`, whose keys are physical
block addresses, while the subsequent cache operation uses the NID-keyed node
cache.
Is the lookup here intended to test the PBA-keyed meta cache or the NID-keyed
node cache?
Yeah, nice catch! I encountered a panic due to this issue, have fixed this
locally, thanks for pointing it out anyway.
Thanks,