Re: [PATCH v2 1/3] dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller

[Krzysztof Kozlowski]

On 21/08/2026 16:04, Akash Kumar wrote:
> Add the device-tree binding documentation for the Cypress cypd6129
> and cypd6229 dual Type-C PD controllers. These are used on Shikra
> CQM/CQS/IQS platforms to handle usb-role-switch for the USB Type-C
> ports over an I2C interface, similarly to the existing cypd4226
> binding.
> 
> cypd6229 is a variant of cypd6129 and is described with a
> "cypress,cypd6129" fallback compatible string.
> 
> Signed-off-by: Akash Kumar <akash.kumar@xxxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/usb/cypress,cypd6129.yaml  | 107 +++++++++++++++++++++
>  1 file changed, 107 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd6129.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd6129.yaml
> new file mode 100644
> index 000000000000..43e2c1902fd1
> --- /dev/null

So another v2? Which one should be reviewed?

Does `b4 diff` work? Try yourself.

Qualcomm has extensive internal guideline, why aren't you following it?


> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd6129.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/cypress,cypd6129.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cypress cypd6129/cypd6229 Type-C Controller
> +
> +maintainers:
> +  - Akash Kumar <akash.kumar@xxxxxxxxxxxxxxxx>
> +
> +description:
> +  The Cypress cypd6129 and cypd6229 are dual Type-C PD controllers that are
> +  controlled via an I2C interface.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: cypress,cypd6129
> +      - items:
> +          - const: cypress,cypd6229
> +          - const: cypress,cypd6129

Where in your changelog did you explain reasons of creating completely
new binding file instead of adding this to existing binding like it was
in v1?

Really, what is happening in this patchset?

Best regards,
Krzysztof