Re: [PATCH v3 01/47] dt-bindings: clock: qcom: gcc-sdm845: Add CX power domain
From: Krzysztof Kozlowski
Date: Tue Aug 25 2026 - 03:35:01 EST
On 25/08/2026 09:30, Abel Vesa wrote:
>>>
>>> required:
>>> @@ -56,6 +58,8 @@ allOf:
>>> - const: bi_tcxo
>>> - const: bi_tcxo_ao
>>> - const: sleep_clk
>>> + required:
>>> + - power-domains
>>
>> Why? Commit msg should tell me why you are changing ABI. It is actual
>> ABI break without an explanation...
>
> Actually, I should've kept the same commit message as for the other
> bindings.
>
> Thanks for reviewing.
The others only mention "to match hardware description" but that is poor
reason for ABI break. If everything was working fine, thus domain is not
really required, why would "matching the hardware description" matter?
Best regards,
Krzysztof