Re: [PATCH 10/13] HID: ft260: uart: fix active-low RTS/CTS/DTR/DSR polarity
From: Linus Walleij
Date: Tue Aug 25 2026 - 04:18:24 EST
Hi Michael,
thanks for your patch!
On Sat, Aug 22, 2026 at 11:40 PM Michael Zaidman
<michael.zaidman@xxxxxxxxx> wrote:
> From: Rio Liu <rio@xxxxxx>
>
> The FT260 modem control GPIOs for RTS, CTS, DTR, and DSR are active-low.
> Invert the TIOCMGET sense and the TIOCMSET drive levels for those pins
> so userspace ioctl state matches the electrical lines. Leave DCD and RI
> unchanged.
>
> Signed-off-by: Rio Liu <rio@xxxxxx>
> Signed-off-by: Michael Zaidman <michael.zaidman@xxxxxxxxx>
Isn't this just fixing a patch earlier in the same series?
Just fold it in with the patch adding this.
Note: GPIOlib has it's own polarity inversion handling, when
you rewrite the serial modem control to use the helpers,
the gpio table will include a flag for polarity inversion, and
then you just put it there.
Yours,
Linus Walleij